مراجعة كل pull request قبل دمجه
العيب نفسه يكلّف إما تعليقًا واحدًا على pull request، أو حادثة واحدة في بيئة الإنتاج. والفارق الوحيد هو متى نظر إليه أحد. تنظر السحلية مرتين: مرة على المستودع الذي لديك أصلًا، ومرة أخرى على كل سطر تدفعه — قبل أن يصل إلى بيئة التشغيل.
واجهة خطر الشيفرة.
خطر عثر عليه الوكيل في طلب دمج: الفرق البرمجي الذي أدخله، والسطر بالتحديد، والرقعة التي كتبها سلفًا. يظل الدمج محظورًا حتى يقرر المسؤول.
Race condition in credit deduction allows a double spend
Merge rejected. The agent stopped this pull request and notified its author. Nothing merges until an owner decides.
TL;DR
Two concurrent requests can both pass the balance check before either writes, so a workspace with 40 credits can start two 40-credit runs. The read and the write are separate statements with no lock and no transaction between them.
Business Impact
Credits are the billing unit, so this is unmetered consumption of paid compute. It is reachable by any authenticated customer with two clients and no special access, and it leaves no anomaly in the ledger — both writes are individually valid.
Technical Analysis
deductCredits reads the balance with a plain SELECT at line 69 and writes the decremented value at line 79. Nothing holds a row lock across the two, and the enclosing handler does not open a transaction, so two callers interleave read-read-write-write and the second write overwrites the first. FOR UPDATE on the read, or a single conditional UPDATE … WHERE balance >= :cost, closes it.
Assumptions
The agent read the diff and the two files it touches. It did not run the service: this is a static finding about a code path, graded on reachability from an authenticated route, not a reproduction against a deployed environment.
Affected Context
- Repository
- acme/platform
- Service
- billing
- Entry point
- POST /api/app/runs
- Scope
- Acme Production Edge
Classification
- Category
- Race condition
- CWE
- CWE-367 · Time-of-check time-of-use race condition
- OWASP
- A04:2021 — Insecure Design
- Confidence
- High (94%)